Skip to content

[IMAS-5328] Rebasing the full set of additions requested in IMAS-5328… #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
imbeauf wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

[IMAS-5328] Rebasing the full set of additions requested in IMAS-5328… #172

imbeauf wants to merge 5 commits into from
+152 −1

Conversation

@imbeauf
Copy link
Collaborator

@imbeauf imbeauf commented Nov 6, 2025 •
edited by github-actions bot
Loading

… onto develop

Draft PR for the moment, just to test if the AL manages to compile with these extensions
@prasad-sawantdesai
@olivhoenen

📚 Documentation preview 📚: https://imas-data-dictionary--172.org.readthedocs.build/en/172/

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Diff of generated Data Dictionary XML file

@deepakmaroo
Copy link
Contributor

deepakmaroo commented Nov 14, 2025 •
edited
Loading

This changes complaining AL-Java compilation issue code too large.
AL-Java code generation to be fix

@imbeauf
[IMAS-5328] Removing the gyrocenter moments to help AL to compile (tr…
1904a99 
…ade-off agreed with the author of the ticket)
@imbeauf
Copy link
Collaborator Author

imbeauf commented Nov 19, 2025

Does it work with this lighter version of the IDS ? I think this would satisfy 90% of the needs of the author of the ticket

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Diff of generated Data Dictionary XML file

@deepakmaroo
Copy link
Contributor

deepakmaroo commented Dec 2, 2025

I apologise, missed this updates and notification.
Tested gyrokinetics_local ids lighter version with AL-Java v5.5.0 and IMAS-Core v5.5.2. AL-Java compilation issue disappeared and it is working fine.
For reference, created AL-Java branch to validate gyrokinetics_local ids https://git.iter.org/projects/IMAS/repos/al-java/commits?until=IMAS-5682-test-gyrokinetics-validate

@olivhoenen olivhoenen marked this pull request as ready for review December 2, 2025 14:07
SimonPinches
SimonPinches reviewed Dec 2, 2025
View reviewed changes
schemas/gyrokinetics_local/dd_gyrokinetics_local.xsd Outdated
</xs:element>
<xs:element name="heat_flux_parallel">
<xs:annotation>
<xs:documentation>Normalized parallel heat flux (integral of 0.5 * m * v_par * v^2)</xs:documentation>
Copy link
Collaborator

@SimonPinches SimonPinches Dec 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below these should be definite integrals, e.g. integral including f over dv ?

Copy link
Collaborator Author

@imbeauf imbeauf Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I am correcting the definitions

imbeauf and others added 2 commits December 3, 2025 09:38
@imbeauf @SimonPinches
Major case
963aa9d 
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
@imbeauf @SimonPinches
Major case
4c35f36 
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Diff of generated Data Dictionary XML file

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Diff of generated Data Dictionary XML file

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Diff of generated Data Dictionary XML file

deepakmaroo added a commit to deepakmaroo/IMAS-Java that referenced this pull request Dec 4, 2025
@deepakmaroo
Added test to validate gyrokinetics_local ids from iterorganization/I…
476633a 
…MAS-Data-Dictionary#172
deepakmaroo added a commit to deepakmaroo/IMAS-Java that referenced this pull request Dec 4, 2025
@deepakmaroo
Added test to validate gyrokinetics_local ids from iterorganization/I…
d70d6eb 
…MAS-Data-Dictionary#172
olivhoenen pushed a commit to iterorganization/IMAS-Java that referenced this pull request Dec 4, 2025
@deepakmaroo @olivhoenen
Added test to validate gyrokinetics_local ids from iterorganization/I…
054a442 
…MAS-Data-Dictionary#172
olivhoenen pushed a commit to iterorganization/IMAS-Java that referenced this pull request Dec 4, 2025
@deepakmaroo @olivhoenen
Added test to validate gyrokinetics_local ids from iterorganization/I…
e41bd3b 
…MAS-Data-Dictionary#172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimonPinches SimonPinches SimonPinches left review comments

@DavidPCoster DavidPCoster DavidPCoster approved these changes

@simpla-fusion simpla-fusion Awaiting requested review from simpla-fusion simpla-fusion is a code owner

@aksinghh aksinghh Awaiting requested review from aksinghh aksinghh is a code owner

@qsthayashi qsthayashi Awaiting requested review from qsthayashi qsthayashi is a code owner

@yegakjh yegakjh Awaiting requested review from yegakjh yegakjh is a code owner

@medvedevsyu medvedevsyu Awaiting requested review from medvedevsyu medvedevsyu is a code owner

@pankin pankin Awaiting requested review from pankin pankin is a code owner

At least 7 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@imbeauf @deepakmaroo @SimonPinches @DavidPCoster